Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating upgrade instructions for v1.2.0 #286

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

TheMarstonConnell
Copy link
Member

No description provided.

Copy link
Contributor

@BiPhan4 BiPhan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible changes?

upgrades/gov-props/v1.2.0.md Outdated Show resolved Hide resolved
upgrades/gov-props/v1.2.0.md Show resolved Hide resolved
BiPhan4
BiPhan4 previously approved these changes Mar 14, 2023
Copy link
Contributor

@BiPhan4 BiPhan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #286 (9c8392e) into master (3b8de28) will increase coverage by 39.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #286       +/-   ##
===========================================
+ Coverage    8.28%   47.58%   +39.29%     
===========================================
  Files         270      229       -41     
  Lines       48859     7943    -40916     
===========================================
- Hits         4050     3780      -270     
+ Misses      44565     3919    -40646     
  Partials      244      244               

see 41 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@BiPhan4 BiPhan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed changes I requested. LGTM!

@TheMarstonConnell TheMarstonConnell merged commit 44073bf into master Mar 14, 2023
@TheMarstonConnell TheMarstonConnell deleted the 1.2.0-upgrade-instructions branch March 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants