PyOpenSci Review - Code Updates #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarified in the README that this is only intended for regression (we should add an equivalent for classification, with different default metrics, that would perhaps involve creating a new abstract function that both this function and the new one would call) - make more general by allowing users to pass in other metrics, or to include their own
This was referenced Sep 22, 2023
Closed
|
I have gone through the commits and the issues/concerns they address and I believe you have addressed and explained everything well. I have no additional concerns on the code or functionality. |
BerylKanali
reviewed
Oct 11, 2023
JacksonBurns
added
the
PR Ready for Review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
3.12 support blocked by RDKit for the time being, will bypass: |
JacksonBurns
force-pushed
the
pyopensci_code_updates
branch
from
9fdbb23
to
132f6b3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains updates to the source code as part of the PyOpenSci review (see pyOpenSci/software-submission#120).
Each commit message contains additional clarifying details.