Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the new version with one 1 conn #5

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

riderx
Copy link
Contributor

@riderx riderx commented Apr 12, 2023

fix: #4

@stackblitz
Copy link

stackblitz bot commented Apr 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: 750e925

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JacobLinCool
Copy link
Owner

First, thank you for your contribution!

But it seems that the test need to be update too, or it just wait until the end of the world... https://github.com/JacobLinCool/node-cloudflared/blob/main/src/_tests/index.test.ts#L25-L26

@JacobLinCool
Copy link
Owner

Ok, it seems that the GitHub Actions is still using the old test.

It looks good to me, and I will merge your PR.

Thank you again for your contribution! 👍

@JacobLinCool JacobLinCool merged commit 07b1119 into JacobLinCool:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Await connection never resolve
2 participants