You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I think the idea is that an EntryID might actually be different. In fact, I think it's a hack that we're using the UID for the EntryID. The EntryID will be user-visible, at least inside the sources. UIDs, other than in debugging (or the dependency graph) really should be invisible.
So, I'm not entirely sure what the context of that quote is, but, from looking at that code snippet, I'm not quite sure that I understand what the need is for the P.Citation data type. Is it meant to be an internal citation with extra restrictions for printing into other artifact types?
In any case, in the spirit of #2788 and #2873, if P.Citation is a chunk type (and I think it should be considered one), then it should have (a) a “drasil”-related UID and (b) a “UID” that it exposes for printing. While they might be equivalent, we shouldn't rely on that coincidence because the UID is internal cruft while the “UID” field that defines the citation is a part of its definition.
Additionally, instead of using showUID, since this chunk is derived from another, we might prefer to use one of the new UID constructors used in #2788.
I believe that P.Citation is an internal type for "printing-ready form for a citation". It is still format independent, but it has been "unpacked".
I think Citation is a chunk type, P.Citation isn't, and doesn't need to be. It is Citation that is a little broken, because it does not contain the needed information, which is the human-printable label we want to refer to this citation as. I think we should take a page out of bibtex (and friends) on how to derive these labels.
From @JacquesCarette,
Specifically,
layCite
should not useshowUID
:Drasil/code/drasil-printers/Language/Drasil/Printing/Import/Document.hs
Lines 102 to 104 in 08c6cdb
The text was updated successfully, but these errors were encountered: