Duplicate "the" (coming from the_ofThe, etc.?)

[samm82]

From my investigation in #3199, I noticed some UnitalChunks with sentences built using the_ofThe, etc. but also having "the" prepended (these specific examples from DblPendulum):

Drasil/code/drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs

Lines 90 to 92 in 1831438

	xVel_1 = makeUCWDS "v_x1" (nounPhraseSent $ phraseNP (horizontalVel `the_ofThe` firstObject))
	(S "The" +:+ phraseNP (QP.angularVelocity `the_ofThe` firstObject) `S.inThe` phrase CM.xDir)
	(sub lV (Concat [labelx, label1])) velU

Drasil/code/drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs

Lines 98 to 100 in 1831438

	yVel_1 = makeUCWDS "v_y1" (nounPhraseSent $ phraseNP (verticalVel `the_ofThe` firstObject))
	(S "The" +:+ phraseNP (QP.angularVelocity `the_ofThe` firstObject) `S.inThe` phrase CM.yDir)
	(sub lV (Concat [labely, label1])) velU

Drasil/code/drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs

Lines 58 to 60 in 1831438

	lenRod_1 = makeUCWDS "l_1" (nounPhraseSent $ phraseNP(len `the_ofThe` firstRod))
	(S "The" +:+ phraseNP (len `the_ofThe` firstRod)) -- Fix me, can have more information
	(sub cL label1) metre

Drasil/code/drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs

Lines 146 to 148 in 1831438

	pendDisAngle_1 = makeUCWDS "theta_1" (nounPhraseSent $ phraseNP (angle `the_ofThe` firstRod))
	(S "The" +:+ phraseNP (angle `the_ofThe` firstRod))
	(sub lTheta label1) radian

I believe this results in "the" being duplicated:

[JacquesCarette]

Nicely spotted!

[cd155]

The problem occurs while using the combination of phraseNP and "the_ofThe".

For example,
nounPhraseSent $ phraseNP (horizontalVel `the_ofThe` firstObject)

the_ofThe will add "the" at the beginning, but the whole word is treated as an NP. The second "the" will be added when we display the description in the definition.

If we change the the_ofThe to ofThe, will remove the extra "the" from the definition. However, this will also remove "The" from the Table of Symbols.

[JacquesCarette]

This code seems to be quite cursed: it really visibly adds the twice. Worse, it does its own capitalization. And it duplicates things too.

[smiths]

At the risk of glossing over a more serious issue, I'm completely fine with the last idea from @cd155. That is, using ofThe is fine with me. The consequence is removing the "The" from the Table of Symbols, but that "The" isn't really necessary. If we say vx1 is the "horizontal velocity of the first object" that is fine with me. We don't have to say "The horizontal velocity of the first object". I looked at the GlassBR example and it isn't full of "the"s in the table of symbols. Including a "The" in the definition of the symbol seems like unnecessary information, especially since we can add a "the" if we want to with the combinators.

[samm82]

I agree with @smiths here; making our descriptions more consistent is a good idea, especially if it also works to remove errors elsewhere. It will be interesting to see the implications of this change!

@JacquesCarette How do you propose handling the duplication? Define a local Sentence (like lenRod_1Desc) and use it twice? We could potentially introduce a UnitalChunk constructor for simple terms (where the term is the description), but means creating more constructors, which could potentially introduce unwanted complexity (#3199).

[JacquesCarette]

Yes, at this point, something as simple as lenRod_1Desc would do. Let's not introduce more constructors, but see what we do in practice first.

[janim2-2004]

@samm82 I am not sure why we use

nounPhraseSent $ phraseNP(len `the_ofThe` secondRod)

instead of just

(len `the_ofThe` secondRod)

[samm82]

Just by looking at the code, me neither. I can't verify that the types all match up with 100% certainty, but if everything works using the second approach, I agree that it is much nicer

[cd155]

Practically, you can change nounPhraseSent $ phraseNP(len `the_ofThe` secondRod) to len `the_ofThe` secondRod, then try to compile Drasil, use stable to see what makes changes in Latex and HTML. If nothing changes, then it looks simpler.