Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsaa required to use lvsfunc.misc.source? #150

Closed
adworacz opened this issue Sep 6, 2022 · 2 comments
Closed

vsaa required to use lvsfunc.misc.source? #150

adworacz opened this issue Sep 6, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@adworacz
Copy link

adworacz commented Sep 6, 2022

It appears that due to how the current __init__.py is setup, attempting to use lvsfunc.misc.source causes scripts to fail when vsaa is not installed.

Can we split up the imports so that vsaa is only imported when its used?

Example stacktrace:

2022-09-05 20:51:02.243: INFO: QSS file successfully loaded.
2022-09-05 20:51:02.243: INFO: Found version patches to be applied.
2022-09-05 20:51:02.243: INFO: Found application patches to be applied.
2022-09-05 20:51:02.404: ERROR: No module named 'vsaa'
2022-09-05 20:51:02.405: ERROR: Traceback (most recent call last):
  File "script.vpy", line 4, in <module>
    import lvsfunc as lvs
  File "/usr/lib/python3.10/site-packages/lvsfunc/__init__.py", line 12, in <module>
    from . import (
  File "/usr/lib/python3.10/site-packages/lvsfunc/aa.py", line 9, in <module>
    import vsaa
ModuleNotFoundError: No module named 'vsaa'
@adworacz
Copy link
Author

adworacz commented Sep 6, 2022

Note also that the AUR build doesn't have the vsaa dependency marked.

@LightArrowsEXE
Copy link
Member

vsaa is part of the requirements.txt and thus should be installed when the user installs/updates lvsfunc. The package should always be available unless you're using some other method to install it than python/pip. So no, this behaviour won't change. Just install the missing package.

Note also that the AUR build doesn't have the vsaa dependency marked.

I don't maintain it, but I don't know if the person who does is still around anymore. Will look, and if he's too inactive to keep maintaining it, I'll remove the README section. For the time being, I suggest just using pip.

@LightArrowsEXE LightArrowsEXE added the wontfix This will not be worked on label Sep 6, 2022
LightArrowsEXE added a commit that referenced this issue Sep 6, 2022
Dave — Today at 13:46
They should just pip nowadays
And vaguely maintained it, havent touched it in year(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants