Also create symlinks when running on Windows #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging @Jake-Shadle because github suppresses notifications on draft PRs, sorry about any noise |
|
I don't understand, how does not creating syminks break clang-cl on windows? The reason for syminks is to fix casing issues on case-sensitive file systems, which windows does not have AFAIK. |
The |
|
I've merged this in #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to ignore symlinks on Windows, breaking support for clang-cl. I have added code to handle them, however this might change the behaviour of the application as creating symlinks on Windows requires the
SeCreateSymbolicLinkPrivilegeprivilege (meaning the user needs to be Administrator or have Developer Mode enabled).In my opinion, users with no such privilege should pass the
--disable-symlinksflag (or maybe make that the default on Windows?)