Add --use-winsysroot-style option to splat #119
Conversation
This option changes the layout of the splat a little to support /winsysroot (ref: https://reviews.llvm.org/D95534) which is more convenient when compiling with clang-cl. Example: `target\release\xwin --accept-license --arch x86_64 --variant desktop splat --include-debug-libs --include-debug-symbols --preserve-ms-arch-notation --disable-symlinks --use-winsysroot-style --output winsysroot`
sgraham
changed the title
|
Does this allow Line 72 in ff780cb If so, might be nice to update the dockerfile with that new option. And if the current file layout is "ad-hoc", maybe it makes sense to deprecate/remove it in favour of winsysroot? |
Yes, that's correct.
I can change it blindly, but I don't know anything about docker. Will that get tested on a CI run?
That would be nice for me as I'm only using the output with clang-cl on Windows. But I don't know how other people are using the outputs, so maybe it would break other workflows/compilers/platforms? |
I'm only using EDIT: It seems we could have already simplified with |
Looking at the .dockerfile it looks like RUSTFLAGS would need to be changed in that case. I'm not sure if it's really easier then, because it appears it wants to point directly at the libdirs, and so they'll have version numbers in them in the case of doing /winsysroot.
Yes, I think so. I haven't used those (older?) versions myself. |
|
@Jake-Shadle any comment on whether it makes sense to use this as default format globally? |
|
I personally don't see the benefit of going from 2 -> 1 command line args, perhaps it's nicer for clang if library directories are also automatically inferred. |
|
It'd simplify the code and testability here a little if there's only one set-in-stone directory layout. Especially if the original one isn't specifically based on anything (is it?). |
|
I'd consider it if this project had a maintenance burden, but it doesn't. |
|
Thanks! |
This option changes the layout of the splat a little to support /winsysroot (ref: https://reviews.llvm.org/D95534) which is more convenient when compiling with clang-cl.
Example:
target\release\xwin --accept-license --arch x86_64 --variant desktop splat --include-debug-libs --include-debug-symbols --preserve-ms-arch-notation --disable-symlinks --use-winsysroot-style --output winsysrootThen:
clang-cl.exe -fuse-ld=lld-link /winsysroot winsysroot src/main.ccI didn't realize when I wrote it, but I see this was requested by someone else in Issue #51.