Remove hard dependency on 'ring' #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And exposes the TLS options as cargo features
Jake-Shadle
approved these changes
May 16, 2022
There was a problem hiding this comment.
Nice, didn't notice any big differences in download speeds with this change and since rustls is still used by default it's up to users if they want to deal with openssl issues. I guess one thing I would change would be to enable the vendored feature of native-tls-crate, but I think that can be done later if someone complains.
|
It'd be great if you can release a new version to crates.io, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use
xwinin PyO3/maturin#919 but currentlyxwinhas a hard dependency on 'ring', and ring doesn't compile on Linux powerpc64le & s390x architectures, so here are some changes to remove 'ring' as a hard dependency.reqwestwithureqand expose TLS dependency options as cargo features. Sincexwinuses the blocking http client before andureqis blocking-IO only this doesn't change much behavior.ringwithsha2