Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to clap 4.0 #61

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Upgrade to clap 4.0 #61

merged 4 commits into from
Oct 14, 2022

Conversation

Copy link
Owner

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle Jake-Shadle merged commit 38d9f8a into Jake-Shadle:main Oct 14, 2022
@messense messense deleted the clap-4 branch October 14, 2022 06:39
@p--b
Copy link

p--b commented Oct 14, 2022

Not that it's incredibly problematic, but FYI - I believe this (as released in xwin v0.2.9) may have caused a semi-backwards-compatibility issue, in that an environment that was previously accepted by the xwin binary is no longer accepted:

  xwin --manifest-version 16 download && xwin --manifest-version 16 splat
  shell: /usr/bin/bash -e {0}
  env:
    XWIN_ACCEPT_LICENSE: 1
error: '1' isn't a valid value for '--accept-license'
  [possible values: true, false]

For more information try '--help'
Error: Process completed with exit code 2.

@Jake-Shadle
Copy link
Owner

Ugh, sorry about that, I think the error is clear enough what has happened and it's an easy fix for users so I think I'll just leave this as is, but thanks for posting about this issue.

@p--b
Copy link

p--b commented Oct 14, 2022

No worries, yes setting the environment variable to "true" works as expected 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants