Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect available port when running headless tests #27

Merged
merged 1 commit into from
Oct 30, 2014
Merged

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Oct 30, 2014

By default the test server tried to run on port 3000, which would fail with a misleading message if something else happened to occupy that port on the system (such as a Rails app).

Now start incrementing the port number from 3900 and stop when the port is found to be available.

By default the test server tried to run on port 3000, which would fail
with a misleading message if something else happened to occupy that port
on the system (such as a Rails app).

Now start incrementing the port number from 3900 and stop when the port
is found to be available.
@dgraham
Copy link
Contributor

dgraham commented Oct 30, 2014

Classic test server failure.

On Oct 30, 2014, at 7:49 AM, Mislav Marohnić notifications@github.com wrote:

By default the test server tried to run on port 3000, which would fail with a misleading message if something else happened to occupy that port on the system (such as a Rails app).

Now start incrementing the port number from 3900 and stop when the port is found to be available.

You can merge this Pull Request by running

git pull https://github.com/github/fetch test-port
Or view, comment on, or merge it at:

#27

Commit Summary

Auto-detect available port when running headless tests
File Changes

M test/run.sh (17)
M test/server.js (4)
Patch Links:

https://github.com/github/fetch/pull/27.patch
https://github.com/github/fetch/pull/27.diff

Reply to this email directly or view it on GitHub.

mislav added a commit that referenced this pull request Oct 30, 2014
Auto-detect available port when running headless tests
@mislav mislav merged commit 430d871 into master Oct 30, 2014
@mislav mislav deleted the test-port branch October 30, 2014 16:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants