Improve Request/Response BodyInit consuming #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (!body) { | ||
| this._bodyText = '' | ||
| } else { | ||
| throw new Error('unsupported BodyInit type') |
There was a problem hiding this comment.
@annevk when handling BodyInit types, whats the correct way to handle unknown types? The spec just says "switch on object's type" with no default case.
Chrome Canary seems to just cast everything via toString().
new Response(function() {}).text()
// "function () {}"
There was a problem hiding this comment.
That is because IDL handles it. And indeed, if there's a primitive value present that is what IDL defaults to.
|
@josh you can iterate over |
(new FormData())[Symbol.iterator] // undefinedDoesn't look even Canary or FF Nightly implement it yet. Anyway, thanks again @annevk! I'll just proceed with those cases being unsupported. |
josh
added a commit
that referenced
this pull request
Jan 16, 2015
Improve Request/Response BodyInit consuming
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Request and Response can accept a number of BodyInit types and are supposed to be consumable via a number of mixin readers.
@annevk seems like we're missing a way to consume
FormDatatypes. Theres no way to turn it into a Blob or ArrayBuffer.new Response(formData).blob()is going to become a clever hack if nothing official defined.