Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup escape issues #629

Closed
JakeStanger opened this issue Jun 3, 2024 · 0 comments · Fixed by #746
Closed

Markup escape issues #629

JakeStanger opened this issue Jun 3, 2024 · 0 comments · Fixed by #746
Labels
bug Something isn't working
Milestone

Comments

@JakeStanger
Copy link
Owner

JakeStanger commented Jun 3, 2024

Describe the bug
#586 introduced Pango support to more places. In some places, the text needs to be (intelligently) escaped, as it is now causing blank strings and GTK warnings.

To Reproduce
Steps to reproduce the behavior:

  1. Add the music module with default settings
  2. Play a song with an & in its title (or where the artist has an &)
  3. Observe GTK warning

Expected behavior

The & is correctly escaped. Markup continues to work as expected.

Additional context

Glib offers a markup_escape_text which will correctly escape Pango markup. This cannot be used on the full string as this then...escapes the markup.

@JakeStanger JakeStanger added the bug Something isn't working label Jun 3, 2024
JakeStanger added a commit that referenced this issue Jun 3, 2024
@JakeStanger JakeStanger added this to the 0.16.1 milestone Aug 10, 2024
JakeStanger added a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant