This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Update DiskLruCache.java #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cache needs to be overwrite by new value
|
what is the benefit that the logic is "dirty.renameTo(clean);" rather than "renameTo(dirty, clean, true)" ? |
|
Run com.jakewharton.disklrucache.DiskLruCacheTest.readAndWriteOverlapsMaintainConsistency will be failure , the cause is snapshot2.getString(0) will not equal "CCcc" in line 287 (the result error is org.junit.ComparisonFailure: expected:<'[CCcc]'> but was:<'[AAaa]' ) the new value was not overwrite the old cache ,because the dirty dos not rename to clean successful. |
|
Changing this would make the commit non-atomic. Additionally, if that test is now failing with the change you are breaking the intended behavior of the snapshots. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cache needs to be overwrite with the new value