-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 14 #48
Comments
I choose 15 by default for everything. There's no reason to support anything less in 99.99% of reasonable cases. That said, send a PR for this and I'll merge it. |
Totally agree, it's just inertia for us since we have a ton of users (1 million...) still on API 14 devices for some reason. That said, I just did some research, and found a solution for this via the ManifestMerger docs.
One can just add the following to their manifest to force their SDK versions over the library: <uses-sdk tools:overrideLibrary="com.jakewharton.rxbinding" /> Much nicer solution than modifying the library itself for everyone, so no worries on needing a PR from me on it now :) Thanks anyway! Wish I'd thought to look for override mechanisms before opening the issue. |
Fair enough. If the customization becomes a problem, it's just one PR away... |
can I override library api v 10?! 6 percent of android devices in our country have gingerbread android version. so we have to support 2.2.3. which functionality can meet problem in this case?! |
As long as you don't use bindings which reference things added after API 10 On Wed, Jun 15, 2016 at 9:24 AM Siavash A notifications@github.com wrote:
|
Back with this again, sorry again :/
All the current tests pass whenever I try with API 14, and I can't find any significant UI changes between 14 and 15 that would impose a limitation on this library in the future.
Totally understand if you'd rather not though, just putting it up for consideration!
The text was updated successfully, but these errors were encountered: