Change the handling of out-of-bounds canvas #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpicDima
commented
Nov 18, 2023
| if (widthDiff == 1) { | ||
| rows.forEach { it.add(newBlankPixel) } | ||
| } else { | ||
| rows.forEach { it.addAll(createBlankRow(widthDiff)) } |
There was a problem hiding this comment.
I think this is not an ideal solution, because several lists are created, but on the other hand it should not be a hot execution path.
|
I would like to write tests for this behavior before committing |
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
7a2f4c4
to
8dd3870
Compare
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
8dd3870
to
2e592ea
Compare
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
2e592ea
to
6d1073b
Compare
|
I haven't forgotten about all these PRs. I'm just busy, but they hover near the top of my "TODO" list and "Feels-bad-about-not-yet-merging" list. |
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
6d1073b
to
9df5a80
Compare
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
9df5a80
to
94800f1
Compare
EpicDima
force-pushed
the
epicdima/change_work_beyond_canvas_borders
branch
from
94800f1
to
3be531a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example from #254
The first picture
The second picture
It seems to be the partial solution for point 5 in #153
Update:
Now this is a simple logic that does not cause crashes, while it allows you to partially draw objects that are partially shifted beyond the border. In the first commit, the canvas expanded automatically, but since this is done in the get method, offset modifier expanded the boundaries, although it should not be as a modifier.