Its own platform implementation of different things #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `mordant` is not used as a layer for this. Also, the dependency on `jline3` has been changed to get only the necessary artifacts.
EpicDima
force-pushed
the
epicdima/own_platforms_implementation
branch
from
93b9ea8
to
dc97a19
Compare
EpicDima
changed the title
|
Let's do Mordant's new support for now, but I'm still open to doing this ourselves. Especially since there's a bunch of cool stuff in modern terminals that would be fun to expose which Mordant does not handle. |
|
Mordant does not support user input for JS, so I decided to hold off on integrating user input into Mosaic. I think this pull request can be closed. I hope it will be on the closed list if there is a need to look at it. |
|
I'm going to expect/actual it. For now in my branch I just dropped JS support, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, then you need to add user input processing and change the samples