Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typing-extensions usage #53

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Update typing-extensions usage #53

merged 3 commits into from
Apr 1, 2024

Conversation

lmmx
Copy link
Contributor

@lmmx lmmx commented Apr 1, 2024 •
edited
Loading

Update typing-extensions usage to align with supported Python versions (i.e. rely on typing.Literal instead now)

The edits were to:

Note: I ran pre-commit linters and files I didn't edit were touched (I'd recommend using the pre-commit.ci bot so all PRs/commits are kept correct)

thomasaarholt
thomasaarholt approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@thomasaarholt thomasaarholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, I hadn't noticed that pre commit hadn't run on all files, can reproduce. We disabled a lot of the checks when we switched upgraded to pydantic 2.0, I'll start bringing them back.

@thomasaarholt thomasaarholt merged commit 4b42826 into JakobGM:main Apr 1, 2024
1 check passed
@lmmx lmmx deleted the typing-ext-fix branch April 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasaarholt thomasaarholt thomasaarholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmmx @thomasaarholt