Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executable not found when the current working directory (cwd) is set to config file path #103

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

wu-vincent
Copy link
Contributor

@wu-vincent wu-vincent commented May 1, 2024

This commit resolves the issue where mkdocs build --config-file mkdocs.yml fails due to the process not properly locating the executable when the current working directory (cwd) is set to a specific path. Fix #75.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wu-vincent - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JakubAndrysek JakubAndrysek merged commit 9f3075a into JakubAndrysek:main May 1, 2024
13 checks passed
@JakubAndrysek
Copy link
Owner

Thank you for your PR 😍

@wu-vincent wu-vincent deleted the fix-popen-file-not-found branch May 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to find an execution issue
2 participants