Add Doxyfile configurations and update Doxygen plugin #98
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JakubAndrysek - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| assert result == expected_result | ||
|
|
||
|
|
||
| # Sets the Doxygen configuration using a custom config file |
There was a problem hiding this comment.
suggestion (testing): Add assertions for the presence of custom configurations in test_set_doxy_cfg_custom_file.
The test currently checks for default configurations being set correctly. It would be beneficial to also assert that any custom configurations provided through the doxyCfgNew parameter are applied correctly. This ensures that custom configurations are not ignored or overwritten by default values.
| @@ -0,0 +1,89 @@ | |||
| from mkdoxy.doxyrun import DoxygenRun | |||
There was a problem hiding this comment.
suggestion (testing): Add tests for hashWrite and hashRead functions.
These functions are crucial for determining whether the source files have changed since the last run. Testing them would ensure that changes are correctly detected, leading to appropriate Doxygen runs.
| @@ -0,0 +1,89 @@ | |||
| from mkdoxy.doxyrun import DoxygenRun | |||
There was a problem hiding this comment.
suggestion (testing): Include tests for hasChanged method.
This method plays a key role in deciding whether to run Doxygen based on changes to the source files. Tests should cover scenarios where files have changed, haven't changed, and edge cases like new files being added or removed.
No description provided.