Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total sum of items for all chars on server #45

Closed
JoeInch opened this issue Jul 9, 2011 · 4 comments
Closed

Total sum of items for all chars on server #45

JoeInch opened this issue Jul 9, 2011 · 4 comments
Labels
✨ enhancement A new feature or improvement request

Comments

@JoeInch
Copy link

JoeInch commented Jul 9, 2011

I was looking if I could add a line for the total number of items on all chars in the tooltip. This seemed to be easy for the actual char, but I was not able to extract the desired information for the remaining chars.
Question: Can a total line be added for all chars?

On my research I found that you obviously intended to display also equipped items. I didn't remember that I had seen any equipped item ever. I believe I found the problem. I think, you are searching for 'e' in the index, but the equipment items are stored as 'ex' or 'exx', where x/xx is the slot number.

@JoeInch
Copy link
Author

JoeInch commented Sep 14, 2011

I have investigated a little further and found a possible solution in db.lua line 316. It should read instead: local size = GetBagSize(bag) or 0 that change causes a) equipped items appear in the list b) a side effect which does not show the items for some chars anymore.
I believe the function GetItemCount is called from different places and the two different versions are needed for the different calls. My hope is, that you can point out the error right away since I am not that good in programming LUA.
My first assumption with the 'e' bag type could not be confirmed.
Many thanks
Joe

@Jaliborc
Copy link
Owner

Jaliborc commented Nov 1, 2011

Fixed on development version

@Jaliborc Jaliborc closed this as completed Nov 1, 2011
@JoeInch
Copy link
Author

JoeInch commented Nov 2, 2011

Hola João,
many thanks for looking into this.

Had you seen my second post about the display of equipped items?
As I wrote, I have solved that by duplicating the function and putting GetBagSize in Version 2.
Version 2 works perfect for equipped items, and the original for bags. But not vice versa.
I'll buy me a book for LUA programming .... but these side effects seem very strange to me.
Many thanks
Hasta luego
Reinhard

-----Ursprüngliche Nachricht-----
Von: João Libório Cardoso [mailto:reply@reply.github.com]
Gesendet: Dienstag, 1. November 2011 17:27
An: Griedelbach, Reinhard
Betreff: Re: [Bagnon] Total sum of items for all chars on server (#45)

Fixed on development version

Reply to this email directly or view it on GitHub:
#45 (comment)
Dell GmbH, Geschäftsanschrift/business address: Unterschweinstiege 10, 60549 Frankfurt am Main, Germany
Geschäftsführer: Mark Möbius, Barbara Wittmann, Jürgen Wilhelm Renz
Sitz: Frankfurt am Main, eingetragen beim Amtsgericht Frankfurt am Main unter HRB 75453
USt.-ID: DE113541138, WEEE-Reg.Nr.: DE 49515708

@Jaliborc
Copy link
Owner

Jaliborc commented Nov 2, 2011

It doesn't really matters, as the Bagnon_Forever and Bagnon_Tooltips have been completely replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature or improvement request
Projects
None yet
Development

No branches or pull requests

2 participants