fix: Issue 50 + added safeSetState + Disposal of HandleChange listener #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated with ValueListenableBuilder<SideMenuDisplayMode>
…error - setState() called after dispose().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes proposed in PR 64
Fixed Issue 50
Added safeSetState - To intelligently handle multiple setState calls without checking the mounted condition for each of them one by one
Handled Disposal of HandleChange listener properly to remove error - setState() called after dispose() . This error appeared after making the ScheduledBinding change in global.dart
These issues were observed while using multiple sideMenus and transitioning between them.