Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue #70 - No static in global + hassle free Multi SideMenu support + Segregated controller from global +Animated Container issue #71

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

aditya113141
Copy link
Contributor

New version release possible

I believe that if the changes pass tests successfully on your side then you can release a new version
with Multiple sideMenus support. Let me know if any edits are needed

  • This PR solves all the issues related with use of multiple sideMenus at the same time. Issue #70
    Solved the issue of static variables in global which were causing hindrance for
    multiple sidemenus to function without sharing their variables
  • Detailed work on removing static nature can be found in this comment
  • Due to rapid toggling, the AnimatedContainer in sidemenu.dart was getting into weird state. Fixed it here
  • Segregated controller from global.dart and fixed the export files. No need of exporting global.dart

@Jamalianpour
Copy link
Owner

Jamalianpour commented Oct 16, 2023

Thank you @aditya113141
Can you update example and readme with this changes?

@aditya113141
Copy link
Contributor Author

aditya113141 commented Oct 16, 2023

@Jamalianpour There is no change required in example. I ran it on my side. There is no issue. I have made changes to the code in a way that the syntax for the developer doesn't changes. Developer can write the code according to documentation of previous version. In readme file, the only change needed is the version of library, if you decide to release a new version with this PR. Otherwise, no change in usage and syntax.

@Jamalianpour Jamalianpour merged commit a5dd10a into Jamalianpour:master Oct 16, 2023
1 check passed
@Jamalianpour
Copy link
Owner

@aditya113141 Sorry, but I have to revert your code because you don't follow flutter/dart lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants