-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a release for django 4.0 compare #260
Comments
Same problem detected still on Django 4.0 |
If not fixed, I am affraid that django-rest-knox will not be usable at all on Django 4.0 ... |
Also The providing_args argument for django.dispatch.Signal is removed. in knox.singals.py Is django-rest-knox still maintained? |
I am also interested in this release. |
After upgrading python 3.8.1 to version 3.8.10, my project stopped working.
Pipfile:
Please suggest me right compatible versions so my project can be fixed. |
For now, I have downgraded django 4 to django 3 and it is working |
@belugame @James1345 |
hey everyone, |
Fully agree with @belugame here, it would even be better if @James1345 could hand-over the pypi name, or someone could claim the pypi name (https://www.python.org/dev/peps/pep-0541/#how-to-request-a-name-transfer). |
Dirty fix is to simply pin to the latest commit: |
I understand, it seems more and more likely that anyone wishing to upgrade to Django 4 will have to rely on a fork. However it would be nice that development would converge on a single fork.
This would be better indeed. Otherwise I suggest that some information should be added to the
|
I'll get a release sorted soon |
Hadn't realised no-one was watching this any more - sorry for the delay folks! |
@James1345 Created a pr #261 to test current python and django version which should help to maintain repo. |
Please implement this I want to use knox with 4.0 🙏
|
@NickWinston123 You do not need a release. As I mentioned in #260 (comment) you can use the latest version. |
I am a noob and didn't know that was a pip command, thanks it is working now! |
As said, it is a dirty fix... I hope a release will be uploaded to pypi |
I'm going to get a release up on PyPI soon, I promise. |
@James1345 any ETA? Thanks! |
I created a 4.2.0 release: https://github.com/James1345/django-rest-knox/releases/tag/4.2.0 for Django <=4 |
Great thank you! Will it be published on pypi.org? |
Yes, I just did so :) |
In
auth.py
from django.utils.translation import ugettext_lazy as _
no longer works asugettext_lazy
is removed.develop
branch seems to have solved this issue.Can a release be created?
The text was updated successfully, but these errors were encountered: