-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Fatal error: Uncaught TypeError: decbin(): Argument #1 ($num) must be of type int, string given #299
Comments
I would be more comfortable seeing a sample file that exhibits this problem first, to see how or where it's being called inappropriately. |
I took a look at your sample file but didn't notice any such warnings. What version of PHP are you using? |
Good tip, the error comes under PHP 8.0.3. I just tried it with PHP 7.4.11, there it runs without problems. That explains then why I have only been observing this for some time. I have not brought it in connection with the switch to PHP 8. |
This issue seems to be the root cause of the issue owncloud/music#867. There, we can find also a stack trace showing that the bad call to getID3/getid3/module.tag.id3v2.php Line 1965 in acf86e0
This line of code is obviously passing in a string while |
Please reopen this issue if 4e5bcaf doesn't fix your problem. |
I just came across a sample MP3 file that exhibited this problem, related to code parsing the RGAD (replay gain) tag improperly. I have rewritten that section of the code in 0bc9aca. |
Fix ChristophWurst#7 Pull in changes from - JamesHeinrich/getID3@4e5bcaf - JamesHeinrich/getID3@0bc9aca Ref JamesHeinrich/getID3#299 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Fix ChristophWurst#7 Pull in changes from - JamesHeinrich/getID3@4e5bcaf - JamesHeinrich/getID3@0bc9aca Ref JamesHeinrich/getID3#299 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Hello James Heinrich
Recently I get more and more often the error when reading files:
Not to exclude that the MP3 files are not quite correct from the structure, on the other hand MP3 Diags can not find errors.
I help myself with additional check in the function
\getid3_lib::Dec2Bin($number)
whether the parameter really contains a number and get out otherwise.getid3.lib.php:429
Does it make sense to apply this change?
Many greetings
Joey
The text was updated successfully, but these errors were encountered: