Sync 2.0 with 1.9.23-202310190849 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions-checkout Update actions/checkout to v3 and upgrade PHPStan
Remove deprecated utf8_encode/utf8_decode
* Add getid3_lib::SafeDiv() which does a division with ternary guard. Avoids repeating the denominator expression. * Rearrange a few formulas to avoid unnecessary divisions. a/(b/c) = a*c/b except that the latter produces an answer when c=0. * Remediate divisions that may possibly divide by zero, or look suspicious. * In module.audio.midi.php: remove unused variable * In module.audio.mp3.php: raise an error for zero channels, since lots of things divide by the channel count. * In module.audio.voc.php: ignore channels=0, pretend channels=1 * In module.graphic.bmp.php: with ExtractData the RLE modes will divide by zero if width=0. With any compression mode, zero width or height means empty data, so add that as a shortcut.
Guard against division by zero
The reciprocal of the actual value was being returned for MPEG-1 video. Files with square pixels were not affected, nor were MPEG-2 files listing a display aspect ratio. Fixes JamesHeinrich#410
This gives a nice 320px result instead of 321 point something when producing square pixel output and is commonly used.
Getting this warning: Binary operation "/" between 1 and 0.0|0.6735|0.7031|0.7615|0.8055|0.8437|0.8935|0.91666666666667|0.9815|1.0|1.0255|1.0695|1.1|1.1575|1.2015|1.3333|1.7778|2.21 results in an error. Hopefully this will convince it that it won't divide by zero?
Fix for MPEG-1 video pixel aspect ratio
It seems confused by the guard for $ratio being 0 :)
One more attempt to please the static analyzer
Fix wrong variable name in JamesHeinrich@ce4a159
clarify wording that new gCL licenses no longer available
Run lint against PHP 8.3
…l_in_favor_of_static_property Moves jpeg segments names from $GLOBALS to class static property
Fix PHP Notice in module.audio-video.riff.php
# Conflicts: # README.md # getid3/module.audio-video.matroska.php # license.txt # phpstan.neon # src/GetID3.php # src/Module/Audio/Shorten.php # src/Module/Audio/module.archive.7zip.php # src/Module/AudioVideo/QuickTime.php # src/Module/Graphic/Bmp.php # src/Write/ID3v2.php
StudioMaX
force-pushed
the
2.0-with-1.9.23-202310190849
branch
from
37a7b67
to
5a3f29c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.