-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALEPH-2018004 - DOS vulnerability #2457
Comments
@thomasvdb I was fighting with the same problem and probably found a way how to mitigate it by setting the MaxDepth serializer setting to 64 (or any other value you expect for your nesting object level) Instead of a stack overflow, you will get a JsonReaderException thrown by the Newtonsoft library. |
Yes, MaxDepth setting is designed for this situation. |
@JamesNK maybe it is worth to set the default MaxDepth value for the json library? Do you have such plans? |
We're using BlackDuck to scan our projects and recently Newtonsoft.Json was flagged as a medium security risk (BDSA-2018-5195) because of the following issue:
The BDSA record points to this article which was created around 2018: https://alephsecurity.com/vulns/aleph-2018004
I've been searching for more information about this issue but can't find anything useful.
Do you have any more information about this?
The article states that the issue has been communicated. Has this been fixed or what's your opinion about this?
The text was updated successfully, but these errors were encountered: