perf(view): ⚡ do not re-create background fetches when searching for …

…span
JamesNZL · May 17, 2023 · 04d0b70 · 04d0b70
1 parent 8dee4b4
commit 04d0b70
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/TogglTrack.cs b/src/TogglTrack.cs
@@ -1415,18 +1415,21 @@ internal async ValueTask<List<Result>> RequestViewReports(CancellationToken toke
 				Grouping = 2,
 			};
 
-			/* 
-			 * Report span selection --- tgl view [day | week | month | year]
-			 */
-			if (query.SearchTerms.Length == ArgumentIndices.Span || !Settings.ViewSpanArguments.Exists(span => span.Argument == query.SearchTerms[ArgumentIndices.Span]))
+			if (query.SearchTerms.Length == ArgumentIndices.Span)
 			{
-				// Start fetch for running time entries asynchronously in the backgroundd
+				// Start fetch for running time entries asynchronously in the background
 				_ = Task.Run(() =>
 				{
-					// TODO: this does too many fetches
 					_ = this._GetRunningTimeEntry(true);
 				});
+			}
 
+			/* 
+			 * Report span selection --- tgl view [day | week | month | year]
+			 */
+
+			if (query.SearchTerms.Length == ArgumentIndices.Span || !Settings.ViewSpanArguments.Exists(span => span.Argument == query.SearchTerms[ArgumentIndices.Span]))
+			{
 				var spans = Settings.ViewSpanArguments.ConvertAll(span =>
 				{
 					return new Result