Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blink OK LED while transmitting #3

Closed
wants to merge 2 commits into from
Closed

Blink OK LED while transmitting #3

wants to merge 2 commits into from

Conversation

FedericoCeratto
Copy link

Blink the LED at every symbol when "-l" is supplied.

@JamesP6000
Copy link
Owner

Hi Frederico,

This is a really neat feature!

Does this work both on the Pi v1 and also the Pi v2?

Also, it seems from the code that the LED blinking feature is always turned
on and cannot be turned off? I don't see any way for blink_led to ever have
the value false? I think the best user interface is to have blink_led be
true by default, but if the user uses the command line option, they can
turn off the led blinking.

James

On Thu, Oct 22, 2015 at 11:16 AM, Federico Ceratto <notifications@github.com

wrote:


You can view, comment on, or merge this pull request online at:

#3
Commit Summary

  • Blink OK LED while transmitting

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

@FedericoCeratto
Copy link
Author

There are claims that the OK LED can be controlled on Pi v2 as well:
https://raspberrypi.stackexchange.com/questions/697/how-do-i-control-the-system-leds-using-my-software/27929
I don't have a v2 to test this hence I made the "-l" flag opt-in.
(Also the other -r -o -s flags are disabled by default)

@michelinok
Copy link

It would be great if we can specify the gpio number to "blink"....I would like to connect an external led and blink it while transmitting...
Is this possible?

@Supremehamster
Copy link

Supremehamster commented Jul 5, 2017

Got it working on my Pi2b (flashing green led - no gpio) - code is here .... only wspr.cpp is different
Supremehamster/WsprryPiLed@df55a60
Used Federico's code and put it where I guessed it should go lol ;)

@FedericoCeratto
Copy link
Author

@michelinok I can't test code changes at the moment, perhaps you could send a PR if/after @JamesP6000 merges this one?

@Supremehamster
Copy link

@michelinok @JamesP6000 Would be nice to merge if James wishes to. I was wondering if adding code has any timing implications? Seems to be ok - mines gone 100km on 100mw (20m) so looking good here.

@dl9sec
Copy link

dl9sec commented Apr 13, 2018

Hi,
i am not very familiar with this github stuff and i don't have a own repository, but the attached patch will give you the suggested TX blink-LED function with the latest sources:
wspr_blinkledtx.zip
I tested it on a good old Raspi 1...
Regards, Thorsten DL9SEC

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants