Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Submitting a patch? #13

Closed
JayVDZ opened this issue Apr 22, 2014 · 5 comments
Closed

Submitting a patch? #13

JayVDZ opened this issue Apr 22, 2014 · 5 comments

Comments

@JayVDZ
Copy link
Contributor

JayVDZ commented Apr 22, 2014

What's the best way to submit a patch? I've been having problems with the FindByEmailAsync method and an invalid cast exception. I've fixed the issue in the patch so would like to submit it for review. I'm new to Git so apologies if how you do this is meant to be obvious.

@Andorbal
Copy link
Contributor

Make a fork of the real repository, clone your fork locally, make your
change, push it to your repository, and then submit a pull request. There
are some instructions here:
https://help.github.com/articles/using-pull-requests

And while I don't have much experience maintaining an open source project,
I think I'd rather have someone want to contribute but not know how than
not contribute at all!

On Tue, Apr 22, 2014 at 4:59 AM, Jay Van Der Zant
notifications@github.comwrote:

What's the best way to submit a patch? I've been having problems with the
FindByEmailAsync method and an invalid cast exception. I've fixed the
issue in the patch so would like to submit it for review. I'm new to Git so
apologies if how you do this is meant to be obvious.


Reply to this email directly or view it on GitHubhttps://github.com//issues/13
.

@JayVDZ
Copy link
Contributor Author

JayVDZ commented Apr 22, 2014

Thanks Andorbal. I'm willing. I'll give it a spin later. I don't mind contributing conventionally but just wanted to get this potential change reviewed first.

@JamesRandall
Copy link
Owner

All contributions gratefully received - thanks Amethi! If you do a pull request as Andorbal has described that does give me the chance to review and merge it before committing it into the master branch.

Really appreciate it.

@JayVDZ
Copy link
Contributor Author

JayVDZ commented Apr 23, 2014

Thanks, pull request made.

@JamesRandall
Copy link
Owner

Thanks Amethi - I've merged this into the master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants