-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
James.yang/var vec mat #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 11, 2020
- More type safety has been added in traits - Model ad_log_pdfs and variable expression to_ad member functions allow users to pass in cache in case these expressions need them. - Dot product finally implemented (performance is still great) - NUTS creates long cache vector (the extra memory for adj and values may not be necessary) - more unittests with dot product
…really important bug in dot
…fied to have universal tolerance lvl
…t params to viewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Expression Checkermoved to later issueGenerative Model Checking:no variable gets assigned a distribution more than onceno variable gets assigned a distribution that references the same variableno distribution references variables below it (ones that are assigned a distribution after current variable)extend fastad to support AD node for DotNodenot needed!multiple chains/coresexceptions for non-activated models before calling inferencemodels are pretty small, so inference can just activate.adaptive metropolismoved to later issuegibbs samplingmoved to later issueOptimization:
sin(x+y) * cos(x+y)
will recomputex+y
twice. Think about having transformed parameters like STAN to do something like(w = x+y, y |= ppl::normal(w, 1.));
This optimization at the user-level that cannot be predicted or optimized from the library any further. User definitely has a say in how to optimize expressions.