Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncpack deletes empty package.json nodes #117

Closed
tylerbutler opened this issue Feb 15, 2023 · 2 comments
Closed

Syncpack deletes empty package.json nodes #117

tylerbutler opened this issue Feb 15, 2023 · 2 comments

Comments

@tylerbutler
Copy link

Description

In syncpack 9.0, empty nodes in package.json are removed. For example, we have a custom node in our package.json that looks like this:

	"typeValidation": {
		"disabled": true,
		"version": "2.0.0-internal.2.1.0",
		"broken": {}
	}

We want to leave the empty broken field, but syncpack deletes it, even when no other package changes are needed. I think the change was in commit a279e56.

Suggested Solution

Ideally, syncpack would only edit fields it's supposed to, so I would expect it to only touch the dependency fields/types that it's configured to.

Alternatively, if the behavior could be disabled altogether, that would work for us, but not sure if that's the best general solution.

@JamieMason
Copy link
Owner

I'll undo that change, sorry about that.

@tylerbutler
Copy link
Author

I'll undo that change, sorry about that.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants