Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blows away line endings in every package.json file with CRLF #76

Closed
Zamiell opened this issue May 29, 2022 · 5 comments
Closed

Blows away line endings in every package.json file with CRLF #76

Zamiell opened this issue May 29, 2022 · 5 comments

Comments

@Zamiell
Copy link

Zamiell commented May 29, 2022

Hello! And thanks for the excellent tool.

From a Windows machine, running syncpack fix-mismatches on my monorepo replaces the line endings in every package.json file with CRLF. (They were LF before.)

This is not good, as it breaks prettier --check and subsequently breaks CI.

Can the tool just copy the existing line endings that are used in the file? Or failing that, always just use LF or something?

@JamieMason
Copy link
Owner

I'm working on Windows support and this will be fixed as part of that, thanks for posting.

@Zamiell
Copy link
Author

Zamiell commented May 29, 2022

Thanks Jamie, appreciate it.

@Zamiell
Copy link
Author

Zamiell commented Jun 24, 2022

Hey Jamie, can I submit a PR to get this done sooner?

JamieMason added a commit that referenced this issue Jun 25, 2022
JamieMason added a commit that referenced this issue Jun 25, 2022
JamieMason added a commit that referenced this issue Jun 25, 2022
@JamieMason
Copy link
Owner

Proposed fix released in 8.2.4

@Zamiell
Copy link
Author

Zamiell commented Jun 25, 2022

Woot, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants