Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versionGroup.dependencyTypes example #98

Closed
wants to merge 1 commit into from

Conversation

dsilvasc
Copy link
Contributor

@dsilvasc dsilvasc commented Sep 27, 2022

Fixes #96

Description (What)

The example for versionGroup.dependencyTypes says peer where it should say peerDependencies

Justification (Why)

Valid dependencyTypes:

export type DependencyType =
| 'dependencies'
| 'devDependencies'
| 'overrides'
| 'peerDependencies'
| 'pnpmOverrides'
| 'resolutions'
| 'workspace';

How Can This Be Tested?

@JamieMason
Copy link
Owner

Great, thanks 👍🏻

@dsilvasc
Copy link
Contributor Author

dsilvasc commented Oct 6, 2022

@JamieMason since this is a PR from a forked repo, I think you need to approve running workflows and/or merging :)

@JamieMason
Copy link
Owner

No worries 👍 just not had any time to do OSS lately. Will pick it up next time I'm working on a round of fixes etc.

@JamieMason
Copy link
Owner

Released in https://github.com/JamieMason/syncpack/releases/tag/8.2.5, thanks @dsilvasc

JamieMason added a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

versionGroup.dependencyTypes takes "peerDependencies" instead of documented "peer"
2 participants