Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/load] guard against broken vml. closes #201 and #200 #202

Merged
merged 6 commits into from
May 26, 2022
Merged

Conversation

JanMarvin
Copy link
Owner

skip names assignment for conditional formatting, this was broken too.

@JanMarvin JanMarvin changed the title [R/load] guard against broken vml [R/load] guard against broken vml. closes #201 May 25, 2022
@JanMarvin
Copy link
Owner Author

Example file is in #201

@JanMarvin JanMarvin changed the title [R/load] guard against broken vml. closes #201 [R/load] guard against broken vml. closes #201 and #200 May 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #202 (8e8dace) into main (805a669) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8e8dace differs from pull request most recent head a7069ef. Consider uploading reports for the commit a7069ef to get more accurate results

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   82.66%   82.71%   +0.04%     
==========================================
  Files          36       36              
  Lines        7397     7399       +2     
==========================================
+ Hits         6115     6120       +5     
+ Misses       1282     1279       -3     
Impacted Files Coverage Δ
R/utils.R 88.57% <100.00%> (+0.33%) ⬆️
R/wb_load.R 95.78% <100.00%> (+0.52%) ⬆️
R/xl_open.R 31.03% <100.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805a669...a7069ef. Read the comment docs.

@JanMarvin JanMarvin merged commit f372e61 into main May 26, 2022
@JanMarvin JanMarvin deleted the vml_br_node branch May 26, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants