Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused spurious warnings in RGui and Visual Studio Code.
@jmbarbone let me know what you think about this (iirc you deprecated
names.wbWorkbook
). In this PR I simply removed the functions altogether, but we could keep them without the deprecation warning (everything else, printing a message will probably pollute the user console as well). The warnings were most likely thrown by IDEs due tonames()
being such an incremental part of R.In addition, should we provide a
names.wbWorkbook
? With this PRnames(wb)
will print all the internal function names.On a side note, we probably should think about a time span for deprecated functions. Do we keep them around until someone finally removes them or for the next dot release or for a time span of x days/weeks/months?