[wb_to_df] modify skipEmptyCols/skipEmptyRows. closes #554 #555
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
commented
Feb 28, 2023
JanMarvin
force-pushed
the
gh_issue_554
branch
from
cab36f3
to
8dd20ed
Compare
jmbarbone
reviewed
Mar 1, 2023
read empty named columns, remove only columns that have no header
jmbarbone
reviewed
Mar 2, 2023
jmbarbone
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part was moved up in the function and is now before
rowNamesandcolNames. Therefore it allows reading empty named columns and remove only columns that have no header.This is a breaking change, because it changes the default behavior of the output. I have nothing against this, but I am not really a user of the
skipEmptyCols/skipEmptyRowsargument. Do you have any suggestions @jmbarbone ?