Fix search by tag and author #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
SagarGi
requested review from
phil-davis,
koebel,
grgprarup,
nabim777 and
nirajacharya2
saw-jan
reviewed
May 31, 2024
saw-jan
approved these changes
May 31, 2024
|
Manually tested LGTM |
nabim777
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the search by tag or author, when search result is empty and then we again do a valid search then the result is empty again. This was because we are depending upon the
peekDatawhich consist of all the blog metadata, and it was dynamically used such that once it become empty it always becomes empty unless the search is empty.This PR saves the searched result value in a separate variable so that the peekData becomes independent to the searched result value.
Fixes: #124