Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom findPagesDir function #39

Merged
merged 2 commits into from
May 4, 2022

Conversation

remorses
Copy link
Contributor

@remorses remorses commented May 3, 2022

findPagesDir in latest next returns an object instead of a path and will probably continue to break in the future, i vendored it in the code

Fix #38

@Janpot
Copy link
Owner

Janpot commented May 3, 2022

But vendoring is not going to help keep its behavior in sync with Next.js versions. Wouldn't it be better to keep importing and just checking whether it returns a string or not?

@remorses
Copy link
Contributor Author

remorses commented May 3, 2022

they don’t apply semver to it so it will break again when they change it

Also, If they change how pages behave then they are changing the whole framework, I don’t think it is going to happen anytime soon

@Janpot
Copy link
Owner

Janpot commented May 4, 2022

👍 Ok, can be merged after the code style issues are resolved

@Janpot Janpot merged commit a78e018 into Janpot:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer works in 12.1.6
2 participants