Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-engineer how calls work in the engine #7152

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix: re-engineer how calls work in the engine #7152

merged 3 commits into from
Dec 19, 2023

Conversation

jgomer2001
Copy link
Contributor

Prepare

Description

Target issue

closes #7064

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@jgomer2001
docs: update docs wrt engine updates #7064
d57b085 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001
test: update and augment test cases and related resources #7064 #6997
b259d9a 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001
fix: revamp method selection & argument conversion strategy #7064
ca119cc 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality labels Dec 19, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed for 'agama parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yurem yurem merged commit a940e7d into main Dec 19, 2023
3 checks passed
@yurem yurem deleted the agama-issue_7064 branch December 19, 2023 16:47
@jgomer2001 jgomer2001 mentioned this pull request Dec 19, 2023
Closed
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@jgomer2001 @devrimyatar
fix: re-engineer how calls work in the engine (#7152)
ddc2d12 
* docs: update docs wrt engine updates #7064

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* test: update and augment test cases and related resources #7064 #6997

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* fix: revamp method selection & argument conversion strategy #7064

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
@mo-auto mo-auto mentioned this pull request Jan 22, 2024
Merged
@mo-auto3 mo-auto3 mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devrimyatar devrimyatar devrimyatar approved these changes

@yurem yurem yurem approved these changes

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(agama): re-engineer how calls are working in the engine
4 participants
@jgomer2001 @yurem @devrimyatar @mo-auto