Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): add missing jans-fido2 ingress #7931

Merged
merged 2 commits into from
Mar 3, 2024
Merged

fix(charts): add missing jans-fido2 ingress #7931

merged 2 commits into from
Mar 3, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 1, 2024 •
edited
Loading

Prepare

Description

Target issue

closes #7889

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
fix(charts): add missing jans-fido2 ingress
89e79b5 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-bug Issue or PR is a bug in existing functionality labels Mar 1, 2024
@iromli iromli marked this pull request as ready for review March 2, 2024 22:05
@iromli iromli requested a review from moabu as a code owner March 2, 2024 22:05
@iromli iromli requested a review from misba7 March 2, 2024 22:05
@moabu moabu merged commit 0f391ce into main Mar 3, 2024
2 checks passed
@moabu moabu deleted the cn-fido2-ingress branch March 3, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@misba7 misba7 Awaiting requested review from misba7

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIDO2 endpoint Ingress missing from Helm charts
3 participants
@iromli @moabu @mo-auto