Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of sync video after render! #4

Closed
zacharyhub opened this issue May 14, 2021 · 6 comments
Closed

out of sync video after render! #4

zacharyhub opened this issue May 14, 2021 · 6 comments

Comments

@zacharyhub
Copy link

I found out that video and audio were out of sync after rendering!

@JargeZ
Copy link
Owner

JargeZ commented May 16, 2021

Hello, can you please tell me if there is a time with a black screen or an image without sound at the end of the video?
Was the render completely finished or was it partial?

And maybe you can send an example of a file with a video in which this was found in telegram: @JargeZ?

@zacharyhub
Copy link
Author

render completely finished.

@Mr-Emerald
Copy link

continuing this thread, a more informative way of saying this would be the frame rate rounds down to the nearest whole number when exporting. for example 29.97 fps rounds down to 29 fps once exported and 59.94 fps rounds down to 59. the video also ends based on when the audio finishes rather than when the video finishes.
explorer_RscN9Iw5ZV
explorer_v78AnnPklx

@JargeZ
Copy link
Owner

JargeZ commented Jul 5, 2021

Oh, @Mr-Emerald thank you very much for helpful a comment!

I will fix this by copying the exact frame rate when creating a video from the original video.
I forgot the existence of non-integer frames per second values, and used int()

JargeZ added a commit that referenced this issue Aug 6, 2021
@JargeZ
Copy link
Owner

JargeZ commented Aug 13, 2021

Hi @Mr-Emerald and @zacharyhub
Can you check this issue with build from this pre-release https://github.com/JargeZ/vhs/releases/tag/v1.5.0

@JargeZ
Copy link
Owner

JargeZ commented Aug 15, 2021

By my checks, this should be fixed.
Reopen, if does not. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants