adding patch for tomcat 8.5.x #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Apr 5, 2017
There was a problem hiding this comment.
Thanks @yudhik!
The changes look good! 👍
In the past only major versions of Tomcat have been added.
I'm tagging @edalquist and @timlevett to see if there would be any objections to adding a minor version.
|
Hi @ChristianMurphy, @edalquist , @timlevett, Looking at http://tomcat.apache.org/whichversion.html, |
timlevett
approved these changes
Apr 6, 2017
|
@andirdju Thanks for the information and the reference! |
|
@timlevett Thanks for reviewing! |
|
@yudhik This is good to go, thanks for the excellent contribution! 👍 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i want to contribute a patching of source code to support tomcat version 8.5.x.
Tomcat 8.5.x is not compatible with 8.0.x, since i'm using 8.5.x and want to have a pre compile jsp plugin, so i try to patch it.
Hopefully it might be useful for other as well.