Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub commit comments no longer sync if not selecting raw source #1114

Closed
adamlui opened this issue Jan 29, 2023 · 5 comments
Closed

GitHub commit comments no longer sync if not selecting raw source #1114

adamlui opened this issue Jan 29, 2023 · 5 comments

Comments

@adamlui
Copy link

adamlui commented Jan 29, 2023

In #1111 I gave you the idea to allow GitHub sync from HTML URLs. However I tested this out recently (when I moved a script into a subdir) and noticed 2 things:

  1. Comments no longer sync with version history
  2. A manual sync was required to update on GF (the v2023.01.29 in screenshot)

image

(v2023.01.29.1+ syncs comments sucessfully because I turned off syncing then re-added the raw source instead)

@JasonBarnabe
Copy link
Collaborator

What URL are you trying to use?

@adamlui
Copy link
Author

adamlui commented Jan 31, 2023 via email

@adamlui
Copy link
Author

adamlui commented Jan 31, 2023 via email

@JasonBarnabe
Copy link
Collaborator

Commit comments are only pulled in when you are using webhooks. If you are using Manual or Automatic syncing, it's just downloading the URL you provide and doesn't know anything about what commit comments you used.

@adamlui
Copy link
Author

adamlui commented Apr 16, 2023

@JasonBarnabe but that's only half the issue, the unresolved half is

A manual sync was required to update on GF (the v2023.01.29 in screenshot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants