Core actions #137
Closed
Core actions #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to target=es6 in the tsconfig is due to the fact that tests fail because CustomSignale is a ES6 class.
|
This pull request has been inactive for awhile; please comment if it's still relevant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #136.
It makes it so that the default logger is a custom version of Signale, with the functionality to log to the workflow run report using the GitHub command syntax.
The
error,fatal,warn, anddebugmethods have been extended so that they log the command instead of the Signale log. You can suppress this behavior by setting{ noIssue: true }in the log options (as documented in the README)startGroupandendGroupare the two new methods to handle log grouping.The target version of the TypeScript build has been bumped to
es6: tests fail whenes5is used, because Signale uses a es6 class that cannot be extended in es5. As stated in this StackOverflow answer, es6 is supported everywhere nowadays, and so it shouldn't be a problem.