Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drain the dead letter event retry block on disposing the DocumentStore #2737

Closed
jeremydmiller opened this issue Sep 27, 2023 · 0 comments · Fixed by #2757
Closed

Drain the dead letter event retry block on disposing the DocumentStore #2737

jeremydmiller opened this issue Sep 27, 2023 · 0 comments · Fixed by #2757
Labels
6.x async daemon bug
Milestone
6.3.0

Comments

@jeremydmiller
Copy link
Member

Will need to implement IAsyncDisposable on DocumentStore. Quick hit, just gotta do it.
@jeremydmiller jeremydmiller added this to the 6.1.0 milestone Sep 27, 2023
@oskardudycz oskardudycz modified the milestones: 6.1.0, 6.3.0 Oct 5, 2023
jeremydmiller added a commit that referenced this issue Oct 19, 2023
@jeremydmiller
Making DocumentStore implement IAsyncDisposable and drain the tombsto…
7929a79 
…ne block on dispose async. Closes GH-2737
@jeremydmiller jeremydmiller mentioned this issue Oct 19, 2023
Merged
jeremydmiller added a commit that referenced this issue Oct 20, 2023
@jeremydmiller
Making DocumentStore implement IAsyncDisposable and drain the tombsto…
def87d2 
…ne block on dispose async. Closes GH-2737
jeremydmiller added a commit that referenced this issue Oct 20, 2023
@jeremydmiller
Making DocumentStore implement IAsyncDisposable and drain the tombsto…
51b67e0 
…ne block on dispose async. Closes GH-2737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.x async daemon bug
Projects
None yet
Milestone
6.3.0
2 participants
@jeremydmiller @oskardudycz