Fixed EventProjection to respect global ordering #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
event_projection_ordering
branch
from
828a215
to
995f70e
Compare
|
Funny, I was going to take this on this morning just to have something easy to start with and do it the exact same way you did it. We might come back a little later in the process and remove the "group it into streams, then ungroup it" work |
oskardudycz
force-pushed
the
event_projection_ordering
branch
from
deb4d0e
to
050d339
Compare
|
@jeremydmiller, sorry for that 😅 I also added a test to reproduce the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Discord discussion with @migajek, we discovered that Event Projection it running everything by the stream, which may cause issues around the global ordering of event processing.
This PR is changing that behaviour as it may be misleading and causing unpredicted issues.
Fixes #2657