Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NGram index on nested property throwing an exception #2839

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mysticmind
Copy link
Member

  • Fix NGram index logic for data config generation and indexname generation
  • Add unit test for ngram index on nested property

Fixes GH-2304

- Fix NGram index logic for data config generation and indexname generation
- Add unit test for ngram index on nested property

Fixes GH-2304
Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@oskardudycz oskardudycz merged commit f12d13d into master Dec 4, 2023
11 checks passed
@oskardudycz oskardudycz deleted the fix_2304 branch December 4, 2023 12:33
@OptimusPi
Copy link

Y'all are awesome 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGramIndex on Inner Property does not work (Runtime Error)
3 participants