Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to index definition CanonicizeDdl #96

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix to index definition CanonicizeDdl #96

merged 1 commit into from
Aug 8, 2023

Conversation

mysticmind
Copy link
Member

  • handle multiple spaces
  • handle parentheses with spaces

@mysticmind
Fix to index definition CanonicizeDdl
92ac46e 
- handle multiple spaces
- handle parantheses with spaces
@mysticmind mysticmind mentioned this pull request Aug 4, 2023
Closed
@mysticmind
Copy link
Member Author

mysticmind commented Aug 4, 2023 •
edited
Loading

Note: Weasel.Postgresql.Tests.Tables.creating_tables_in_database.create_with_multi_column_pk is failing in CI, unrelated to the PR changes.

oskardudycz
oskardudycz approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Babu!

@oskardudycz oskardudycz merged commit fde34aa into JasperFx:master Aug 8, 2023
2 checks passed
@mysticmind mysticmind deleted the index_def_parentheses_space_handling branch August 8, 2023 09:44
@oskardudycz oskardudycz added this to the 6.1.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskardudycz oskardudycz oskardudycz approved these changes

@jeremydmiller jeremydmiller Awaiting requested review from jeremydmiller

Assignees
No one assigned
Labels
bug Something isn't working delta calculation postgres
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mysticmind @oskardudycz