Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct key handling in examples #191

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

frazane
Copy link
Contributor

@frazane frazane commented Mar 16, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In some of the examples, the same PRNGKey is used to generate both x and the noise in y, and x is sorted to avoid the correlation resulting by using the same key. This could be somewhat confusing for new users (myself included).

What is the new behavior?

We simply split the key and use two separate keys to generate x and the noise in y.

@thomaspinder
Copy link
Collaborator

Thanks @frazane - this looks great!

@thomaspinder thomaspinder merged commit 6ebdeed into JaxGaussianProcesses:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants